Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type of resolution CLI flag #595

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

TinfoilSubmarine
Copy link
Contributor

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Does this pull request reference an issue (i.e. bug or enhancement)? If not, you should probably create one. If it is a very simple / small change, this is not needed and just describe the issue below.
  • Make sure to link this pull request to the issue after the pull request is created.
  • Anyone can review this but make sure to add at least one administrator (anyone who can be found under Reviewers)
  • Make sure to add necessary documentation (if appropriate)
  • Once the pull request is created, ensure that the pre-merge checks all run succesfully.
  • If you add a file that requires copyright updates, this will be automatically done via pre-merge checks and pushed to your branch.

Description

Without this, I am getting this error:

$ python3 livestream.py MySsid SuperSecurePa55word rtmp://192.168.1.235/test_stream --resolution 4
usage: livestream.py [-h] [--min_bit MIN_BIT] [--max_bit MAX_BIT] [--start_bit START_BIT] [--resolution {4,7,12}]
                     [--fov {0,4,3}] [--log LOG] [--identifier IDENTIFIER]
                     ssid password url
livestream.py: error: argument --resolution: invalid choice: '4' (choose from 4, 7, 12)

@tcamise-gpsw
Copy link
Collaborator

This seems valid and we'll need to do the same check for the fov argument.

But first it looks like I need to fix some GH action deprecation problem. I'll do that than rebase this branch

@tcamise-gpsw
Copy link
Collaborator

@TinfoilSubmarine can you bring in the latest changes from main to run the checks again?
And also add the "type=int" to the fov argument?

@tcamise-gpsw
Copy link
Collaborator

hmmm Mypy does not seem to like this for some reason. I'll set it up and test it

@tcamise-gpsw tcamise-gpsw merged commit dd41950 into gopro:main Sep 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants